Hi Eric,
We apologize for the misunderstanding. The relationship of that field was confusing, since some files have authors that don't correlate to SVN history at all.
In relation to what eVb was saying, I have looked up the entire SVN history of the misc.c file, which originally started out in NTOS.
Your one and only actual contribution is here:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/hal/x86/misc.c?revision=1026&view=markup&pathrev=2188
Revision 1026, almost 10 years ago.
In that revision, you created the file and "implemented" HalHandleNMI.
It is interesting that your implementation of HalHandleNMI happens to print out the exact same messages that the NT4 HAL dumps on the screen.
To obtain the same messages "clean-room", you must've been able to generate all the possible NMI traps on your machine, which is unlikely.
Also, the choices of "0x40", "0x20" and "0x61" appear to be magic constants, instead of properly documented constants referring to the NMI status port and the NMI status bits.
Additionally, the same "KeEnterKernelDebugger" call is present both in the NT4 HAL and your implementation of this function, even though, as of revision 1993:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdebug.c?revision=1993&view=markup&pathrev=2188
That function only printed a string -- so there appears to have been little reason to make this API call other than to duplicate the original NT HAL's behavior.
Furthermore, why even implement this function at all back in 2000? There was no NMI task gate back then, no NMI handler, and no caller of HalHandleNMI -- therefore, this function was impossible to test in ReactOS. It seems to have been implemented just for the sake of implementing "an easy function", without any actual real use.
Whether this function, in 2000, was by coincidence an exact replica of the NT4 HAL HalHandleNMI, and you happened to have experienced all possible NMI traps and their messages on the screen, and you decided not to document the port and status bit values, or whether it was reverse engineered does not change the fact that the code was 100% identical. Therefore, I believe this was eVB's point that the true "copyright" of this function belonged to nobody else but Microsoft, and so the PROGRAMMERS field seemed logical to include the maintainer, not the "copyright" owner.
So before lambasting about copyright ownership and licenses, perhaps you should be more careful.
It is an entirely different argument whether or not there is any other way to do this -- clearly, by now, it is known what NMI messages the Windows STOP screen will display, and ReactOS must display the same NMI messages. Since both Windows NT and ReactOS use the same routine for printing to the screen, it also makes sense that they'd both be using the same HalDisplayString API. One could argue that since you'd probably want to debug the NMI, it might make sense to enter the kernel debugger, which, since it is an exported kernel function that ReactOS must implement, ends up being the same call as Windows. So whether it was clean roomed, copied, reverse engineered, or fabricated out of thin air to match this specification, the resulting code would look the same (however, it should be better documented so the values don't look like magic). Of course these are all rational arguments that can be made *after* the function has been written, the burden of proof as to IF this is how the function was already written is what matters.
There are many questions as to whether or not those 6 lines of code are actually copyrighted at all, whether you or anyone else has any rights to those 6 lines of code since they are identical to Windows (by necessity), and whether or not the addition of ~460 additional lines to misc.c and improvement of the original function still enable you to refuse a GPL->BSD license change solely based on 6, 10-year-old, lines of code that are identical to an even older copyrighted source base.
To push this analogy further, I could decide that the following piece of code
"printf("%s\n","
is GPL, and block anyone from ever using it in a module that is BSD.
I think even GPL requires at least 10 lines of code before being able to claim the whole module is GPLed (and it's probably more complicated than that).
So to close the topic: it is unclear if you have any ownership of those original 6 lines of code, and it is even further unclear if 6 lines of interface code in a 466 line module allow you the right to dictate the license of the module.
-r
> Ros Arm wrote:
> > The "ownership" and "copyright" of this code is not belonging to either you or anyone else but the original source it came from.
> >
> > The PROGRAMMERS field indicates who is responsible for a piece of code in this project, is it not? In this case, since you have quitted many years ago, it makes sense this code is now belong to us.
> >
> > It is Linux concept of "maintainer".
> >
> > Thanks you,
> > [eVb]
> >
>> Hi Ros Arm,
>> you are totally wrong here. The PROGRAMMERS field could be called
> AUTHORS or CONTRIBUTORS and lists those who claim copyright or
> authorship to a file. So removing someone from the PROGRAMMERS field is
> a very disrespectul act, is a copyright violation and must be reverted
> as soon as possible.
>> You can claim sole authorship to a file if you created the initial
> version of a file.
>> You can also claim authorship to a file if you modified it in a
> significant way. In this case you can ADD your name to the END of the
> list of programmers. So the author who wrote the first version should
> always stay on top of the list. Changing a "+" to "-" or adding "+ 1" is
> not enough to claim authorship.
>> And in no case you have the right to change the license of an existing
> file without having prior permission to do so by ALL authors of that
> file. As far as I can remember, I did NOT grant permission to relicense
> my code under the BSD license. My contributions to ReactOS were, are and
> will be published under GPL or LGPL only.
>> Therefore I ask you to revert the following patch:
> [ros-diffs] [ros-arm-bringup] 44860: NMI Support Patch 6: [HAL]: Fix NMI
> recursion issues. [HAL]: Reset the display during NMI and paint the NMI
> Screen of Death.
>> In case you fail to revert the patch within a week (aka 7 days) I will
> revert this patch myself and restore the previous version.
>> And by the way, DON'T INTRODUCE YET ANOTHER FUCKIING CODING STYLE!!!!
> Use the coding styles that are already being used!!!!
>> Oh, and before I'm done: I don't like to talk to meaningless nicks like
> Ros Arm, RosLeg or ROSIDONTKNOWHOWTOFUKINGCALLMYSELF. Reveal your
> identity! I don't see a reason why you have to hide behind you nick. If
> you need to hide your identity you should better leave ReactOS because
> these reasons can only endanger the project. And I will always prefer to
> throw a single contributor out of the team rather than endangering the
> whole project.
>> And finally, my name is Eric Kohl and I joined the ReactOS project in
> December 1998. So I guess I have the right to voice my opinion here.
>>> Regards
> Eric
>> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
More information about the Ros-dev
mailing list
CHAPTER VII. THE FOUR CLASSES OF SOCIETY. THE FOUR CLASSES OF SOCIETY. "After the herald had given the names of the wrestlers who were to make the first round, the fellows came in. They were dressed without any clothes to speak of, or rather they were quite undressed, with the exception of a cloth around their loins. They came in on opposite sides of the ring, and stood there about five feet apart, each man resting his hands on his knees, and glaring at the other like a wild beast. They[Pg 231] looked more like a pair of tigers than human beings, and for a moment I thought it was not at all unlike what a bull-fight in Spain might be. I turned upon her choking with anger, but her melting beauty rendered me helpless. Black woods were on our left. "Shall we turn in here?" I asked. "None of that with me," he growled. "Do you know who I am, Countess Lalage? I am Leon Lagage, Count of the Holy Roman Empire, and your husband. Incomparable woman, you cannot alter that fact. For better or worse, for richer or poorer, till death do us part!" I have in this way imperfectly indicated a methodical plan of generating a design, as far as words alone will serve, beginning with certain premises based upon a particular work to be performed, and then proceeding to consider in consecutive order the general character of the machine, mode of operation, movements and adjustments, general arrangement, strains, special arrangement, and proportions. ‘Alas! what is life, what is death, what are we, 11th January two best dresses. Commencement was as usual, with a few showers “All right,” agreed Sandy. “Dick, you and I are the ground crew. As soon as you’re ready, Mr. Whiteside, we’ll take hold!” Effects of Walpole's Administration—Formation of the new Ministry—Attitude of the Malcontents—Committee of Inquiry into Walpole's Administration—Walpole's Protectors—Ministerial Measures—Prorogation of Parliament—Disasters of the French—British Division in the Netherlands—Opening of Parliament—The German Mercenaries—Amendment of the Gin Act—George goes to Germany—Stair and De Noailles in Franconia—Stair in a Trap—Bold Resolution of King George—The Battle of Dettingen—Resignation of Stair—Retreat of the French—Negotiations for Peace—Treaty of Worms—Pelham becomes Prime Minister—The Attacks of Pitt on Carteret—Attempted Invasion of England—Its Failure—Progress of the French Arms—Frederick II. invades Bohemia—His Retirement—Resignation of Carteret—Pelham strengthens his Ministry—Death of the Emperor—Campaign in Flanders—Battle of Fontenoy—Campaign of Frederick II.—The Young Pretender's Preparations—Loss of the Elizabeth—Landing in the Hebrides—The Highland Clans join him—The First Brush—Raising of the Standard—Cope's Mistake—He turns aside at Dalwhinnie—Charles makes a Dash for Edinburgh—The March to Stirling—Right of the Dragoons—The "Canter of Coltbridge"—Edinburgh surprised by the Highlanders—Charles marching against Cope—Battle of Prestonpans—Delay in marching South—Discontent of the Highland Chiefs—The Start—Preparations in England—Apathy of the Aristocracy—Arrival of the Duke of Cumberland—Charles crosses the Border—Capture of Carlisle—The March to Derby—Resolution to retreat—"Black Friday"—The Retreat—Recapture of Carlisle—Siege of Stirling—Battle of Falkirk—Retreat to the Highlands—Cumberland's Pursuit—Gradual Collapse of the Highlanders—Battle of Culloden—Termination of the Rebellion—Cruelty of the Duke of Cumberland—Adventures of the Young Pretender—Trials and Executions—Ministerial Crisis. The next morning he was up betimes, and cooked the boys as good a breakfast as he could out of the remainder of his store and what he could get from the hospital, and then gave what was left to whoever came. The comfortable crib, which had cost the Deacon so much labor, had been pre-empted by the Surgeon for some of his weakest patients. "You two step forward one pace," he commanded. "Gentleman, I've got my six. The rest are yours." "Where are you goin'?" he said sternly. Every now and then the crowd would break into the latest rhymings of MacKinnon's poet: A large thicket, at this moment, gave the dusty foot an opportunity of doubling, and, for an instant, diverging from the straightforward course, though it availed him little, he seemed to feel the breath of his pursuer on the back of his neck; his foot sounded as if at his heels; he drew his garment closely around him, turned suddenly to the right, and, bounding from the ground, the next instant a splash was heard in the little river, and the fugitive was safe from his pursuer. HoME明日之后怎么免费刷一级纳米材料
ENTER NUMBET 0018kgem.net.cn krse.com.cn www.xjqg.com.cn www.huryes.com.cn zgjxcm.com.cn www.xuezuo.com.cn yhestate.com.cn mujiaju.com.cn lyxssnc.com.cn www.yuwenjie.com.cn